Mage_Log - DOC block update #767
Conversation
sreichel
commented
Jun 23, 2019
sreichel
commented
- doc blocks added/fixed
- PSR2 fixes (whitespaces, linebreaks, ...)
- doc blocks added/fixed - PSR2 fixes (whitespaces, linebreaks, ...)
| @@ -58,6 +58,9 @@ protected function _construct() | |||
| $this->_init('log/log'); | |||
| } | |||
|
|
|||
| /** | |||
| * @return float|int | |||
There was a problem hiding this comment.
why float? the config description is "Save Expired Items Days" and default value is "180"
There was a problem hiding this comment.
Mage::getStoreConfig(self::XML_LOG_CLEAN_DAYS) returns a string ... multiplied its float.
There was a problem hiding this comment.
ok, so we need a casting to int here.
I propose we either skip this docbloc change, and open a new PR fixing the docblock and adding cast.
There was a problem hiding this comment.
created an issue for this change #949
| @@ -158,6 +187,9 @@ public function getUrl() | |||
| return $url; | |||
| } | |||
|
|
|||
| /** | |||
| * @return mixed | |||
There was a problem hiding this comment.
why mixed? I wold expect rather int
There was a problem hiding this comment.
I've used mixed only in a very few cases, where multiple return types are possble. Mixed/object are on todo list as mentioned in #784.
| @@ -166,6 +198,9 @@ public function getFirstVisitAt() | |||
| return $this->getData('first_visit_at'); | |||
| } | |||
|
|
|||
| /** | |||
| * @return mixed | |||
| @@ -58,6 +58,9 @@ protected function _construct() | |||
| $this->_init('log/log'); | |||
| } | |||
|
|
|||
| /** | |||
| * @return float|int | |||
There was a problem hiding this comment.
created an issue for this change #949
|
thanks @sreichel ! 🎉 |
I am happily surprised :) Didnt check ... if this is discussed in discord plmk. |
